RFR: 8244855 : Remove unused "getParent" function from Windows jni_util_md.c
Lance @ Oracle
lance.andersen at oracle.com
Tue May 12 19:12:25 UTC 2020
+1
Best,
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com
Sent from my iPad
> On May 12, 2020, at 3:05 PM, Brent Christian <brent.christian at oracle.com> wrote:
>
> Hi,
>
> Please review this change to remove the unused "getParent()" function from jni_util_md.c on Windows.
>
> https://bugs.openjdk.java.net/browse/JDK-8244855
>
> Automated build+test job is in progress.
> The diff is as follows:
>
> diff -r ee4bd700b772 src/java.base/windows/native/libjava/jni_util_md.c
> --- a/src/java.base/windows/native/libjava/jni_util_md.c Tue May 12 11:20:34 2020 -0700
> +++ b/src/java.base/windows/native/libjava/jni_util_md.c Tue May 12 12:00:39 2020 -0700
> @@ -31,17 +31,6 @@
> #include "jni.h"
> #include "jni_util.h"
>
> -static void getParent(const TCHAR *path, TCHAR *dest) {
> - char* lastSlash = max(strrchr(path, '\\'), strrchr(path, '/'));
> - if (lastSlash == NULL) {
> - *dest = 0;
> - return;
> - }
> - if (path != dest)
> - strcpy(dest, path);
> - *lastSlash = 0;
> -}
> -
> void* getProcessHandle() {
> return (void*)GetModuleHandle(NULL);
> }
>
> Thanks,
> -Brent
More information about the core-libs-dev
mailing list