RFR [15] 8245231 Javadoc for the readObject methods needs to be updated (8244342 followup)
Joe Wang
huizhe.wang at oracle.com
Mon May 18 22:04:29 UTC 2020
As it appears, I was missing a comma in the header as well (see
https://bugs.openjdk.java.net/browse/JDK-8245238)
The webrev is updated with the comma added (to PredicatedNodeTest.java)
http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
Thanks,
Joe
On 5/18/2020 1:53 PM, Joe Wang wrote:
> Thanks Mark.
>
> -Joe
>
> On 5/18/2020 1:49 PM, mark sheppard wrote:
>> Hi Joe,
>>
>> all good I think.
>>
>> regards
>> Mark
>>
>> ------------------------------------------------------------------------
>> *From:* Joe Wang <huizhe.wang at oracle.com>
>> *Sent:* Monday 18 May 2020 19:36
>> *To:* mark sheppard <macanaoire at hotmail.com>;
>> core-libs-dev at openjdk.java.net <core-libs-dev at openjdk.java.net>
>> *Cc:* Mark Sheppard <mark.sheppard at oracle.com>
>> *Subject:* Re: RFR [15] 8244342: Compilation warnings about
>> unexpected serialization related method signatures.
>> Thanks Mark! I missed that, and I was also 20 min too fast on the
>> checkin :-)
>>
>> Here's a catch-up patch, pls review:
>> http://cr.openjdk.java.net/~joehw/jdk15/8245231/webrev/
>>
>> -Joe
>>
>> On 5/18/2020 10:21 AM, mark sheppard wrote:
>>> Hi Joe,
>>> do your changes warrant a java doc change for readObject
>>> in each LocPathIterator PredicatedNodeTest, and UnionPathIterator ?
>>>
>>> regards
>>> Mark
>>>
>>> ------------------------------------------------------------------------
>>>
>>> *From:* core-libs-dev <core-libs-dev-bounces at openjdk.java.net>
>>> <mailto:core-libs-dev-bounces at openjdk.java.net> on behalf of Joe
>>> Wang <huizhe.wang at oracle.com> <mailto:huizhe.wang at oracle.com>
>>> *Sent:* Friday 15 May 2020 17:54
>>> *To:* core-libs-dev at openjdk.java.net
>>> <mailto:core-libs-dev at openjdk.java.net>
>>> <core-libs-dev at openjdk.java.net>
>>> <mailto:core-libs-dev at openjdk.java.net>
>>> *Subject:* RFR [15] 8244342: Compilation warnings about unexpected
>>> serialization related method signatures.
>>> Hi,
>>>
>>> Please review a fix for the compilation warnings. Thanks Roger for the
>>> detailed instructions! If you could verify the fix with the
>>> work-in-progress processor, that would be great too. Regular build and
>>> test passed.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8244342
>>> http://cr.openjdk.java.net/~joehw/jdk15/8244342/webrev/
>>>
>>> Thanks,
>>> Joe
>>
>
More information about the core-libs-dev
mailing list