RFR: 8215401: Add isEmpty default method to CharSequence

Roger Riggs Roger.Riggs at oracle.com
Tue May 19 16:56:48 UTC 2020


Hi Claes,

Looks good, Thanks for the test.

p.s.  I probably would have used a data provider for the CS cases but 
its not significant.

On 5/19/20 6:37 AM, Claes Redestad wrote:
> Hi Roger,
>
> sure, added Emptiness.java with a few sanity tests.
>
> /Claes
>
> On 2020-05-19 00:29, Roger Riggs wrote:
>> Hi Claes,
>>
>> Though it does not look like it could be any simpler, there should 
>> probably be a test.
>> Checking consistency with the existing implementations of 
>> CharSequence.length()
>> and a custom subtype.
>>
>> Thanks, Roger
>>
>>
>> On 5/18/20 4:48 PM, Claes Redestad wrote:
>>> Hi,
>>>
>>> let's add an isEmpty default method to CharSequence!
>>>
>>> Webrev: http://cr.openjdk.java.net/~redestad/8215401/open.00/
>>> RFE:    https://bugs.openjdk.java.net/browse/JDK-8215401
>>> CSR:    https://bugs.openjdk.java.net/browse/JDK-8215402
>>>
>>> Testing: tier1-3
>>>
>>> /Claes
>>



More information about the core-libs-dev mailing list