RFR: 8215401: Add isEmpty default method to CharSequence

Claes Redestad claes.redestad at oracle.com
Wed May 20 15:21:24 UTC 2020



On 2020-05-20 16:10, Alan Bateman wrote:
> 
> 
> On 19/05/2020 20:35, Claes Redestad wrote:
>> Hi Jason,
>>
>> I guess overriding and marking the CharBuffer method final for
>> consistency wouldn't hurt. Except I probably need to pass this through
>> another CSR review.
>>
>> Also added test cases for char[] and String-based CharBuffers:
>>
>> http://cr.openjdk.java.net/~redestad/8215401/open.01/
> 
> Yes, CharBuffer sometimes needs attention default methods are added to 
> CharSequence. In this case it shouldn't need anything but overriding the 
> javadoc is okay (just missing @since 15).

Ok - I'll also update and resubmit the CSR with the edits and additions
that came up during review here.

> For the test then you could expand it to test the views of heap and 
> direct buffers (asCharBuffer).

How about this:

http://cr.openjdk.java.net/~redestad/8215401/open.02/

/Claes


More information about the core-libs-dev mailing list