RFR: 8245455: Remove alternative StringConcatFactory strategies

Claes Redestad claes.redestad at oracle.com
Fri May 22 11:53:33 UTC 2020



On 2020-05-22 13:43, Aleksey Shipilev wrote:
> On 5/22/20 11:52 AM, Claes Redestad wrote:
>> Webrev: http://cr.openjdk.java.net/~redestad/8245455/open.00/
> 
> The experience with dealing with string concat bugs tells me we better leave at least one strategy
> as the fallback. It does not have to be very optimized, but it needs to be definitely correct. BC_SB
> seems to fit the bill here.
> 

Do you have any example of a case when one of the fallbacks was used to
work around any issues? We've heard of no such case.

BC_SB has a rather intricate dependency on ASM, and recent stabilization
work done to the default strategy will need to be duplicated. If we were
to keep a fallback (which I don't think we actually need), I'd prefer
keeping either MH_SB_SIZED or MH_SB_SIZED_EXACT.

/Claes


More information about the core-libs-dev mailing list