[aarch64-port-dev ] RFR (XXL): 8223347: Integration of Vector API (Incubator): AArch64 backend changes

[Paul Sandoz]

HI Andrew,

Thanks for looking. 

I am not terribly familiar with the AArch64 code, but I would note the Vector API comes with a bunch of unit tests should exercise the code gen, just not as directly as I presume you would like.

To what extent do you feel we can follow up with additional issues and fix them after the initial integration?

Paul.


> On May 22, 2020, at 6:00 AM, Andrew Haley <aph at redhat.com> wrote:
> 
> On 5/19/20 11:55 AM, Yang Zhang wrote:
>> Following up on review requests of API [0], Java implementation and
>> test [1], General Hotspot changes[2] for Vector API and x86 backend
>> changes [3]. Here's a request for review of AArch64 backend changes
>> required for supporting the Vector API:
>> 
>> JEP: https://openjdk.java.net/jeps/338
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8223347
>> Webrev: http://cr.openjdk.java.net/~yzhang/vectorapi/vectorapi.rfr/aarch64_webrev/webrev.01/
>> 
>> Complete implementation resides in vector-unstable branch of panama/dev
>> repository [4].
> 
> This looks great, and it's very impressive. Unfortunately, there are few
> of us sufficiently knowledgeable about Panama to review it in the detail
> that perhaps it deserves. I'm happy with it.
> 
> However, we need tests for the new assembly instructions, so please add some
> to aarch64_asmtest.py and update macroassemler.cpp.
> 
> Also, aarch64.ad is getting to be far too large, and perhaps all the vector
> stuff should be moved into a new file. Thanks.
> 
> -- 
> Andrew Haley  (he/him)
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> https://keybase.io/andrewhaley
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
>