[8u] RFR: 8244843: [JDK 8u] JapanEraNameCompatTest fails

Andrew Hughes gnu.andrew at redhat.com
Sat May 23 10:48:11 UTC 2020



On 15/05/2020 10:22, Severin Gehwolf wrote:
> Hi Andrew,
> 
> Sigh, I only now realized that the bug number was missing the
> subject. Fixed now.
> 

snip...

>>>
>>
>> Only issue with the patch itself is java.time.japanese.short.Eras is
>> missing the new Reiwa era. I guess this is because 11u has JDK-8159943,
>> which refactors these files so they share blocks where possible, before
>> JDK-8219781. Thus, there is only one block to change in 11u, but it's a
>> shared block which is then used from both java.time.japanese.short.Eras
>> & java.time.japanese.long.Eras
> 
> Should be fixed in 03 here. Thanks for the catch:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8244843/03/webrev/
> 
> Thoughts?
> 
> Thanks,
> Severin
> 

I thought I replied to this about a week ago, but I can find no trace of
doing so :/

Anyway, this version looks fine. Please flag with jdk8u-fix-request and
let's get it fixed.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



More information about the core-libs-dev mailing list