RFR(S): 8245600: Clean up libjli

Mikael Vidstedt mikael.vidstedt at oracle.com
Tue May 26 17:24:55 UTC 2020



> On May 22, 2020, at 4:27 AM, Alan Bateman <alan.bateman at oracle.com> wrote:
> 
> 
> 
> On 22/05/2020 04:28, Mikael Vidstedt wrote:
>> Please review this change which cleans up the libjli related files a bit:
>> 
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8245600
>> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8245600/webrev.00/open/webrev/
>> 
> Looks good, don't have a strong opinion on the function name but if I were doing this when I'd probably got for something like CurrentTimeMicros.

I liked it so much I changed it.

> Minor nit is that the JLI_TraceLauncher usages in java.c probably don't need to be across two lines now.

Fixed.


I made the changes and pushed the change. Here’s the final webrev for completeness:

http://cr.openjdk.java.net/~mikael/webrevs/8245600/webrev.01/open/webrev/

Cheers,
Mikael



More information about the core-libs-dev mailing list