RFR: JDK-8245831: Unify code parsing version strings on Mac and Windows

Andy Herrick andy.herrick at oracle.com
Wed May 27 14:05:57 UTC 2020


looks good

curious why app.identifier was added to cfg file.  I don't see it used 
anywhere.

/Andy

On 5/26/2020 3:26 PM, Alexey Semenyuk wrote:
> Please review fix [2] for jpackage bug [1].
>
> Get rid of duplicated code parsing version strings. Move the code 
> parsing version strings to dedicated classes with unit test coverage. 
> Also remove Mac specific identifier setting in app's config file from 
> the shared code.
>
> - Alexey
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8245831
>
> [2] http://cr.openjdk.java.net/~asemenyuk/8245831/webrev.00
>


More information about the core-libs-dev mailing list