RFR(xs): 8242281: IntStream.html#reduce doc should not mention average

Pavel Rappo pavel.rappo at oracle.com
Fri May 29 13:27:21 UTC 2020


Daniel, have you considered that comment from Paul Sandoz to that CSR?

> IMHO removing the @see is not necessary in this respect, it's useful to point to related reduction methods.

https://bugs.openjdk.java.net/browse/JDK-8245970?focusedCommentId=14341561&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14341561

> On 29 May 2020, at 14:14, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi,
> 
> You should also remove the @see #average() tag.
> I see this was already proposed in the CSR.
> 
> When you push make sure to push with 8242281 (which is the bug id)
> and not with 8245970 - which is the CSR id. I have corrected
> the subject to help archeological search of the mail archive.
> 
> best regards,
> 
> -- daniel
> 
> 
> On 29/05/2020 10:04, Conor Cleary wrote:
>> Hi,
>> The method-level documentation of Intstream::reduce(int, IntBinaryOperator) mentions the average function as a case of reduction even though the function cannot be used with the reduce method. This might cause confusion, this fix therefore removes the mention of the average function from the @apiNote.
>> bug: https://bugs.openjdk.java.net/browse/JDK-8245970
>> webrev: http://cr.openjdk.java.net/~jboes/ccleary/webrevs/8242281/webrev.00/
>> Regards,
>> Conor
> 



More information about the core-libs-dev mailing list