RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.
Andy Herrick
andy.herrick at oracle.com
Fri May 29 23:12:26 UTC 2020
On 5/29/20 7:00 PM, alexander.matveev at oracle.com wrote:
> Hi Andy,
>
> Why we need error.lock-resource?
because resource was used , but never defined.
>
> Also, I do not like 194 limit obtained by testing, since once new
> files are introduced in runtime this value might not work anymore. Can
> we check on actual file paths to make sure they have valid length?
I don't like it either, but otherwise we need to test length every time
we create a path, and the check needs to be platform dependent.
/Andy
>
> Thanks,
> Alexander
>
> On 5/29/20 7:36 AM, Andy Herrick wrote:
>> Please review jpackage fix at [1] to issue [2]
>>
>> /Andy
>>
>> [1] http://cr.openjdk.java.net/~herrick/8246010/webrev.01/
>>
>> [2] https://bugs.openjdk.java.net/browse/JDK-8246010
>>
>
More information about the core-libs-dev
mailing list