[PATCH] Typo in java.util.regex.Pattern

[naoto.sato at oracle.com]

Looks good!

Naoto

On 5/30/20 3:40 PM, Lance Andersen wrote:
> All good Naoto
> 
> Here is the revised diff
> 
> —————
> $ hg diff src/java.base/share/classes/java/util/regex/Pattern.java
> *diff -r 968b57610c0f 
> src/java.base/share/classes/java/util/regex/Pattern.java*
> *--- a/src/java.base/share/classes/java/util/regex/Pattern.java  Sat May 
> 30 10:33:28 2020 +0530*
> *+++ b/src/java.base/share/classes/java/util/regex/Pattern.java  Sat May 
> 30 18:39:02 2020 -0400*
> @@ -760,7 +760,7 @@
>    *
>    * <p> For a more precise description of the behavior of regular 
> expression
>    * constructs, please see <a 
> href="http://www.oreilly.com/catalog/regex3/">
> - * <i>Mastering Regular Expressions, 3nd Edition</i>, Jeffrey E. F. Friedl,
> + * <i>Mastering Regular Expressions, 3rd Edition</i>, Jeffrey E. F. Friedl,
>    * O'Reilly and Associates, 2006.</a>
>    * </p>
>    *
> ljanders-mac:open ljanders$
> ---------------
> 
> 
> Best
> Lance
>> On May 30, 2020, at 6:35 PM, naoto.sato at oracle.com 
>> <mailto:naoto.sato at oracle.com> wrote:
>>
>> Thanks, Pavel. I think the year stays 2006 then.
>> Sorry, Lance, for the false alarm.
>>
>> Naoto
>>
>> On 5/30/20 2:34 PM, Pavel Rappo wrote:
>>> I'm holding a copy in my hands right now. I can see "ISBN: 
>>> 978-0-596-52812-6" written on the back of the book. Searching that 
>>> number in the database yields the following record:
>>>     Mastering Regular Expressions
>>>     ISBN-13: 9780596528126
>>>     ISBN-10: 0596528124
>>>     Author: Friedl, Jeffrey E. F.
>>>     Edition: Third
>>>     Binding: Paperback
>>>     Publisher: O'Reilly Media
>>>     Published: August 2006
>>> I think it's reasonable to assume that a changeset pushed in November 
>>> 2006 was referring to a book published no later than that. Certainly, 
>>> not in August 2009. Which is what the page refers to 
>>> http://shop.oreilly.com/product/9780596528126.do Is it a newer print 
>>> of the same edition? It does looks like it.
>>> I would use the original patch as is.
>>> -Pavel
>>>> On 30 May 2020, at 19:13, naoto.sato at oracle.com 
>>>> <mailto:naoto.sato at oracle.com> wrote:
>>>>
>>>> Just noticed that the release year of the 3rd ed. should also be 
>>>> changed to 2009 in the next line.
>>>>
>>>> Naoto
>>>>
>>>> On 5/30/20 4:02 AM, Lance Andersen wrote:
>>>>> I can sponsor this for you
>>>>> Best
>>>>> Lance
>>>>> --
>>>>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>>>> Oracle Java Engineering
>>>>> 1 Network Drive
>>>>> Burlington, MA 01803
>>>>> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>>>>> Sent from my iPhone
>>>>>> On May 29, 2020, at 10:25 PM, Hong Shao Yang 
>>>>>> <hongsy2006 at gmail.com> wrote:
>>>>>>
>>>>>> Hi!
>>>>>>
>>>>>> I found a typo which has been long undetected in the documentation.
>>>>>>
>>>>>> In case you think this is worthwhile, I would appreciate it if someone
>>>>>> can sponsor this patch.
>>>>>>
>>>>>> Cheers,
>>>>>> Shao Yang
>>>>>>
>>>>>> ========= PATCH ==========
>>>>>>
>>>>>> diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java
>>>>>> b/src/java.base/share/classes/java/util/regex/Pattern.java
>>>>>> index 0d7d0738965..82325d04f25 100644
>>>>>> --- a/src/java.base/share/classes/java/util/regex/Pattern.java
>>>>>> +++ b/src/java.base/share/classes/java/util/regex/Pattern.java
>>>>>> @@ -760,7 +760,7 @@ import jdk.internal.util.ArraysSupport;
>>>>>>  *
>>>>>>  * <p> For a more precise description of the behavior of regular 
>>>>>> expression
>>>>>>  * constructs, please see <a 
>>>>>> href="http://www.oreilly.com/catalog/regex3/">
>>>>>> - * <i>Mastering Regular Expressions, 3nd Edition</i>, Jeffrey E. 
>>>>>> F. Friedl,
>>>>>> + * <i>Mastering Regular Expressions, 3rd Edition</i>, Jeffrey E. 
>>>>>> F. Friedl,
>>>>>>  * O'Reilly and Associates, 2006.</a>
>>>>>>  * </p>
>>>>>>  *
> 
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering
> 1 Network Drive
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
>