RFR: 8255380: (zipfs) ZipFileSystem::readExtra can fail if zipinfo-time is not set to false [v2]

[Lance Andersen]

On Sun, 1 Nov 2020 22:21:25 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> LGTM. Some nits inline.
> 
> I guess the test can be cause for issues in some test systems since it needs to write out the 4Gb+ file. Is this why you've only enabled it on linux and mac? Perhaps someone might have ideas on how to improve this.

To validate the test, requires info-zip which comes on Mac and linux.  It is not included with windows.  There are no issues if the Zip is created via java.util.zip or Zip FS

> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 2993:
> 
>> 2991:             // We need to read the LOC extra data and the LOC offset was obtained
>> 2992:             // from the EXTID_ZIP64 field.
>> 2993:             if(hasZip64LocOffset) {
> 
> Suggestion:
> 
>             if (hasZip64LocOffset) {

Resolved

-------------

PR: https://git.openjdk.java.net/jdk/pull/987