RFR: 8256018: Adler32/CRC32/CRC32C missing reachabilityFence [v2]

Naoto Sato naoto at openjdk.java.net
Wed Nov 11 15:33:59 UTC 2020


On Wed, 11 Nov 2020 11:58:08 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Hi, 
>> 
>> Please review the fix for JDK-8256018 which addresses the issue that  the update(ByteBuffer)  methods of Adler32, CRC32, and CRC32C should use Reference.reachabilityFence to ensure that direct byte buffer are kept kept alive when they are accessed directly.
>> 
>> The Mach5 jdk-tier1, jdk-tier2, jdk-tier3 as well as the  jck:api/java_util/zip,jck:api/java_util/jar continue to run clean.
>> 
>> Best
>> Lance
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove extra blank line

Still looks good.

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1149


More information about the core-libs-dev mailing list