RFR: 8247781: Day periods support [v13]
Naoto Sato
naoto at openjdk.java.net
Thu Nov 12 23:11:15 UTC 2020
On Thu, 12 Nov 2020 21:49:16 GMT, Stephen Colebourne <scolebourne at openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Addressed the following comments:
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522185469
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522187931
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522203757
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522211444
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522244221
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522262379
>> - https://github.com/openjdk/jdk/pull/938#discussion_r522266836
>
> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 5063:
>
>> 5061: }
>> 5062: Long moh = context.getValue(MINUTE_OF_HOUR);
>> 5063: long value = (hod * 60 + (moh != null ? moh : 0)) % 1_440;
>
> `long value = Math.floorMod(hod, 24) * 60 + (moh != null ? Math.floorMod(moh, 60) : 0);`
>
> and remove the next three lines
Thanks, Stephen. I made the changes based on your comments.
-------------
PR: https://git.openjdk.java.net/jdk/pull/938
More information about the core-libs-dev
mailing list