RFR: 8256037: [TESTBUG] com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails due to the hard coded threshold is small

[Aleksei Efimov]

On Mon, 9 Nov 2020 09:19:44 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> May I get reviews for this change?
> 
> com/sun/jndi/dns/ConfigTests/PortUnreachable.java fails occasionally on some of our testing platforms.
> The reason is that the hard coded Threshold (1000 ms) [1] is a little smaller than that (e.g., 1026 ms) on our platforms.
> 
> The fix just increases the threshold from 1000 ms to 3000 ms.
> Any comments?
> 
> Thanks.
> Best regards,
> Jie
> 
> [1] https://github.com/openjdk/jdk/blob/master/test/jdk/com/sun/jndi/dns/ConfigTests/PortUnreachable.java#L49

Hi @DamonFool,
Change looks good to me since 3 seconds is less than 15 seconds of the full timeout.

The full timeout interval which is mentioned in the test summary is 15 s:
4 retries with initial timeout set to 1s: 1 + 2 + 4 + 8 = 15 s

-------------

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.java.net/jdk/pull/1116