RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently
Brian Burkhalter
bpb at openjdk.java.net
Thu Nov 19 20:04:06 UTC 2020
On Thu, 19 Nov 2020 19:58:16 GMT, Naoto Sato <naoto at openjdk.org> wrote:
> The code looks good. Should we also change the @implSpec, as it specifically describes how it works, i.e., calling no-arg read(), but the new impl calls read() with buffer.
Good catch. Yes, the `@implSpec` should be updated. I was too focused on the code and performance test and missed that. I'll update that and file a CSR. Thanks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1329
More information about the core-libs-dev
mailing list