RFR: 8246739: InputStream.skipNBytes could be implemented more efficiently [v2]
Roger Riggs
rriggs at openjdk.java.net
Thu Nov 19 20:46:06 UTC 2020
On Thu, 19 Nov 2020 20:20:17 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Please review this modification of `java.io.InputStream.skipNBytes(long)` to improve its performance when `skip(long)` skips fewer than the requested number of bytes. In the current implementation, `skip(long)` is invoked once and, if not enough bytes have been skipped, then `read()` is invoked for each of the remaining bytes to be skipped. The proposed implementation instead repeatedly invokes `skip(long)` until the requested number of bytes has been skipped, or an error condition is encountered. For cases where `skip(long)` skips fewer bytes than the number requested, the new version was measured to be up to more than one thousand times faster than the old version. When `skip(long)` actually skips the requested number of bytes, the performance difference is insignificant.
>
> Brian Burkhalter has updated the pull request incrementally with two additional commits since the last revision:
>
> - 8246739: InputStream.skipNBytes could be implemented more efficiently
> - 8246739: InputStream.skipNBytes could be implemented more efficiently
Marked as reviewed by rriggs (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/1329
More information about the core-libs-dev
mailing list