RFR: 8256299: Implement JEP 396: Strongly Encapsulate JDK Internals by Default [v3]

Mark Reinhold mr at openjdk.java.net
Thu Nov 19 23:08:22 UTC 2020


On Thu, 19 Nov 2020 19:51:59 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Mark Reinhold has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add "Add-Exports" case for the setAccessibleNonPublicMemberNonExportedPackage test
>
> test/jdk/tools/launcher/modules/illegalaccess/IllegalAccessTest.java line 387:
> 
>> 385:                 "--illegal-access=permit");
>> 386:     }
>> 387: 
> 
> I see `setAccessibleNonPublicMemberExportedPackage` test case testing with `--add-exports` and `--add-opens` and `Add-Opens` in JAR file manifest but not testing with `Add-Exports`.
> 
> Is it worth to include the `Add-Exports` test case?
> 
> Other than this, looks good.

Good point -- case added.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1324


More information about the core-libs-dev mailing list