RFR: 8256865: Foreign Memory Access and Linker API are missing NPE checks [v2]

Tue Nov 24 05:30:57 UTC 2020

On Mon, 23 Nov 2020 18:22:14 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Both the Foreign Memory Access and the Foreign Linker APIs leave something to be desired when it comes to handling NPEs - first, most of the API javadoc is oblivious to NPEs being thrown. Secondly, not all API method implementations add expicit NPE checks - with the result of NPE often being thrown very deep in the call chain - if at all. Third, test for API coverage of nulls is ad-hoc.
>> 
>> This patch rectifies all these issues. To increase coverage for null injected into APIs, this patch introduces a new framework for testing an API in bulk, so that all methods are reflectively called with some values replaced with nulls, so that all combinations are tried.
>> 
>> I've also added, as part of this patch, a test to cover the statics in MemoryAccess which were not covered throughly.
>
> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix cut/paste error in FunctionDescriptor

Unused imports in TestLayouts.java?

-------------

Marked as reviewed by sundar (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1388