RFR: 8256486: Linux/Windows-x86 builds broken after JDK-8254231 [v5]

Jorn Vernee jvernee at openjdk.java.net
Tue Nov 24 14:01:57 UTC 2020


On Tue, 24 Nov 2020 13:31:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove JNI_ENTRY_CPP_NOENV
>>  - - Move reset_last_Java_frame
>
> This looks fine to me. PIty to see `CATCH` on the exception recovery path, but that seems okay for the incubating code.

Discussing this with Maurizio as well; FWIW, after we change the Java code that gets called, to handle all exceptions, the CATCH should never trigger. It will just be there as a sanity check.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1266


More information about the core-libs-dev mailing list