RFR: 8257184: Upstream 8252504: Add a method to MemoryLayout which returns a offset-computing method handle [v2]
Maurizio Cimadamore
mcimadamore at openjdk.java.net
Fri Nov 27 17:57:57 UTC 2020
On Fri, 27 Nov 2020 12:31:12 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> This upstreams the patch from: https://github.com/openjdk/panama-foreign/pull/396
>>
>> There were only some minor merge conflicts due to imports and some tests being replaced by java/foreign/TestNulls. All tests still pass, no other changes were needed.
>>
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8257187
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments:
> - remove explicit @throws NPE tags
> - add example to class doc
Very nice
src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/MemoryLayout.java line 177:
> 175: * access coordinate.
> 176: *
> 177: * <p>A layout path with free dimensions can also be used to create an offset computing method handle, using the
Suggestion:
* <p>A layout path with free dimensions can also be used to create an offset-computing method handle, using the
-------------
Marked as reviewed by mcimadamore (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1468
More information about the core-libs-dev
mailing list