RFR: 8257074 Update the ByteBuffers micro benchmark [v3]

Chris Hegarty chris.hegarty at oracle.com
Fri Nov 27 19:22:00 UTC 2020


Maurizio,

> On 27 Nov 2020, at 18:04, Maurizio Cimadamore <mcimadamore at openjdk.java.net> wrote:
> 
> ...
> Looks a great improvements. Two comments:
> 
> * the names always mention the "Single" word, when in fact all benchmark involve some kind of a loop. I'd suggest making that more  explicit, both in the benchmark method and in the helpers.

Yeah, I dislike (the preexisting) “Single” too. How about “Loop” - so we have [Bulk|Loop] ?

> * I see that you added  support for views - but note that, for heap buffers there are two different kind of views (!!). E.g. I believe that:
> 
> ByteBuffer.allocate(size * 4).asFloatBuffer()
> returns a buffer of a different class than:
> 
> FloatBuffer.allocate(size);
> I think you are only testing the former?

Correct.  I did consider the latter, but then thought that this micro had enough scenarios.  Let me take another look and see how much more scenarios it adds.

-Chris.




More information about the core-libs-dev mailing list