RFR: 8253751: Dependencies of automatic modules are not propagated through module layers [v2]

Alan Bateman alanb at openjdk.java.net
Mon Nov 30 18:17:01 UTC 2020


On Wed, 25 Nov 2020 22:09:11 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Formatting nit
>>  - Merge
>>  - Merge
>>  - Merge
>>  - Add @bug to test
>>  - Fixed typo in comment
>>  - Merge
>>  - Merge
>>  - If module reads automatic module in parent configuration then reads all automatic modules
>
> src/java.base/share/classes/java/lang/module/Resolver.java line 580:
> 
>> 578:                     if (m2.descriptor().isAutomatic()) {
>> 579:                         m2.reads()
>> 580:                                 .stream()
> 
> Nit: not sure if this formatting is intentional or you meant `m2.reads().stream()` in one line (which I like better).

Thanks, I suspect I just hit Return and the IDE formatted it. Fixed now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1391


More information about the core-libs-dev mailing list