RFR: 8173585: Intrinsify StringLatin1.indexOf(char) [v2]
Jason Tatton
github.com+70893615+jasontatton-aws at openjdk.java.net
Fri Oct 2 08:41:01 UTC 2020
On Mon, 21 Sep 2020 10:11:28 GMT, Volker Simonis <simonis at openjdk.org> wrote:
>> Jason Tatton has updated the pull request with a new target base due to a merge or a rebase. The pull request now
>> contains four commits:
>> - Merge master
>> - 8173585: further whitespace changes required by jcheck
>> - JDK-8173585 - whitespace changes required by jcheck
>> - JDK-8173585
>
> test/hotspot/jtreg/compiler/intrinsics/string/TestStringLatin1IndexOfChar.java line 24:
>
>> 22:
>> 23: public static void main(String[] args) throws Exception {
>> 24: for (int i = 0; i < 100_0; ++i) {//repeat such that we enter into C2 code...
>
> The placement of the underscore looks strange to me. I'd expect it to separate thousands (like 1_000) if at all but not
> sure if id use it for one thousand at all as that's really not such a big number that it is hard to read..
> Also, the Tier4InvocationThreshold is 5000 so I'm not sure youre reaching C2?
I have added Tier4InvocationThreshold=200 to the unit test config in order to trigger generation earlier
-------------
PR: https://git.openjdk.java.net/jdk/pull/71
More information about the core-libs-dev
mailing list