RFR: 8245194: Unix domain socket channel implementation [v13]

Michael McMahon michaelm at openjdk.java.net
Fri Oct 2 13:19:40 UTC 2020


On Fri, 2 Oct 2020 12:58:02 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   unixdomainchannels: error in the last commit in make/modules/java.base/Copy.gmk
>
> make/modules/java.base/Copy.gmk line 195:
> 
>> 193: 	$(call MakeTargetDir)
>> 194: 	$(RM) $@ $@.tmp
>> 195: 	$(foreach f,$(NET_PROPERTIES_SRC_LIST),$(CAT) $(f) >> $@.tmp;)
> 
> This can be simplified. Cat takes multiple files as input, so no need for 'foreach'. Also no need to go via a temp
> file. We have make configured to delete targets if a recipe fails, so the tmp dance isn't needed. (I know we still have
> this pattern all over the place, but we are trying to quit the practice)

Good points. I will update as suggested. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/52


More information about the core-libs-dev mailing list