RFR: 8251989: Hex formatting and parsing utility
Roger Riggs
Roger.Riggs at oracle.com
Fri Oct 2 20:42:50 UTC 2020
Hi Douglas,
The javadoc and descriptions of prefix and suffix could use some
reinforcement
that they apply only to the formatted bytes of the array.
Adding Byte to the method names makes them a bit unwieldy.
Thanks, Roger
On 10/2/20 12:16 PM, Douglas Surber wrote:
> This looks good overall. I would change the names of withPrefix and withSuffix to withBytePrefix and withByteSuffix and add some words to their JavaDoc clarifying that they apply to the individual bytes.
>
> Douglas
>
>
> PR: https://git.openjdk.java.net/jdk/pull/482 <https://git.openjdk.java.net/jdk/pull/482>
>
More information about the core-libs-dev
mailing list