RFR: 8229186: Improve error messages for TestStringIntrinsics failures [v6]

[Evgeny Nikitin]

On Thu, 1 Oct 2020 19:51:00 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Evgeny Nikitin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use SB to build TestStringIntrinsics message, avoid type guessing in ArrayDiff
>
> test/lib-test/jdk/test/lib/format/ArrayDiffTest.java line 38:
> 
>> 36:  * @run testng jdk.test.lib.format.ArrayDiffTest
>> 37:  */
>> 38: public class ArrayDiffTest {
> 
> Might be it makes sense to check null values. Also, reversed checks. For example there is first = [1, ..], second = [].
> But no check for  first = [], second = [1, ..] for some cases,

Fixed in the 39992fcba97. That ended in finding a minor issue, actually
([ArrayDiff.java:180](https://github.com/openjdk/jdk/pull/112/commits/39992fcba979a2f6bf7ea73aff92461b13220ee2#diff-374ead0149950fce10be8d9d37cca320L180)).
Sometimes reversing can be valuable, thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/112