RFR: 8253761: Wrong URI syntax printed by jar --describe-module
Alan Bateman
alanb at openjdk.java.net
Sat Oct 3 19:21:38 UTC 2020
On Thu, 1 Oct 2020 14:35:50 GMT, Christian Stein <cstein at openjdk.org> wrote:
>> The change looks good.
>>
>> test/jdk/tools/jar/modularJar/Basic.java has tests for jar --describe-module and maybe we could add a test to this to
>> make sure that it outputs the expected JAR URL.
>
>> `test/jdk/tools/jar/modularJar/Basic.java` has tests for jar --describe-module and maybe we could add a test to this to
>> make sure that it outputs the expected JAR URL.
>
> Tests are always good to have.
>
> Should I extend the existing `@Test public void describeModuleFoo() ...` method or should I add a new method that
> ensures the expected URL is emitted?
A new assert in the describeModuleFoo test would be great, thank you!
-------------
PR: https://git.openjdk.java.net/jdk/pull/393
More information about the core-libs-dev
mailing list