RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v2]
Severin Gehwolf
sgehwolf at openjdk.java.net
Mon Oct 5 08:39:48 UTC 2020
On Sun, 4 Oct 2020 18:12:14 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java line 72:
>
>> 70: * Pattern explanation:
>> 71: *
>> 72: * /`````\ /`````\ /`````\ /```````\ /```````\ /```\ (8) /```````\ (10) + (11)
>
> Alternatively, consider the inline comment:
>
> private static final Pattern MOUNTINFO_PATTERN = Pattern.compile(
> "^[^\\s]+\\s+[^\\s]+\\s+[^\\s]+\\s+" + // (1) + (2) + (3)
> "([^\\s]+)\\s+([^\\s]+)\\s+" + // (4) + (5) - group 1,2: mount point, mount options
> "[^-]+-\\s+" + // (6) + (7) + (8)
> "([^\\s]+)\\s+" + // (9) - group 3: fstype
> ".*$"); // (10) + (11)
Good suggestion. I've changed it to what you've suggested and removed the unused groups 1 and 2.
-------------
PR: https://git.openjdk.java.net/jdk/pull/485
More information about the core-libs-dev
mailing list