RFR: 8253761: Wrong URI syntax printed by jar --describe-module
Christian Stein
cstein at openjdk.java.net
Mon Oct 5 15:56:41 UTC 2020
On Mon, 5 Oct 2020 14:47:43 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> I can't find the `modularJar/Basic.java` test run in the logs. In which job/tier/part does it hide?
>>
>>> I think the change exposes issues in a couple of tests.
>>
>> The one that fails the linked "pre-submit test" run above is already reported as
>> https://bugs.openjdk.java.net/browse/JDK-8249095 ("Aux.java" is not a valid file name on Windows).
>>> It looks like partialUpdateFooModuleInfo (modularJar/Basic.java) expects the wrong result, as does some of the tests in
>>> mmrjar/Basic.java.
>>
>> Something for a follow-up issue/PR?
>
> The tests are test/jdk/tools/jar/modularJar/Basic.java and test/jdk/tools/jar/mmrjar/Basic.java. I've verified that
> they will fail with the update to the jar tool so we'll need to change this as part of this PR.
> The tests are in the core_tools test group, which seems to be tier2. I suspect the pre-submit job is running tier1.
I replaced all occurances of `"/!"` with the correct `"!/"` delimiter in both test files.
Hoping that I touched every failing assertion, as I am still struggling to set up a working JDK build environment
locally. On Windows...
-------------
PR: https://git.openjdk.java.net/jdk/pull/393
More information about the core-libs-dev
mailing list