RFR: 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) [v3]
Severin Gehwolf
sgehwolf at openjdk.java.net
Tue Oct 6 08:34:42 UTC 2020
On Mon, 5 Oct 2020 19:22:04 GMT, Bob Vandette <bobv at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typo in comment
>
> src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemFactory.java line 150:
>
>> 148: // find anyway in that case.
>> 149: try (Stream<String> mntInfo = CgroupUtil.readFilePrivileged(Paths.get(mountInfo))) {
>> 150: boolean anyCgroupMounted = mntInfo.anyMatch(CgroupSubsystemFactory::noSystemdCgroupLine);
>
> I'd prefer a similar approach to the hotspot side where you do a positive check for controllers we are interested in
> rather than a negative check for systemd.
OK. I'll probably fold JDK-8254001 into this one then.
-------------
PR: https://git.openjdk.java.net/jdk/pull/485
More information about the core-libs-dev
mailing list