Integrated: 8253750: use build-stable default seed for Utils.RANDOM_GENERATOR
Igor Ignatyev
iignatyev at openjdk.java.net
Tue Oct 6 20:38:09 UTC 2020
On Tue, 29 Sep 2020 00:06:02 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review the patch which updates `jdk.test.lib.Utils` to use md5 hash-sum of `java.vm.version` property
> as default seed for `Utils.RANDOM_GENERATOR`?
> from JBS:
>> using the same seed for all runs of a build will make it possible (easier) to compare results from different test runs
>> (e.g. on different platforms, w/ different flags) and consequently will make test results analysis easier. the proposed
>> solution is to use the seed based on Runtime.version() / "java.vm.version", which are different from build to build, if
>> there is no seed specified by "jdk.test.lib.random.seed" property.
>
> the patch also updates `RandomGeneratorTest` test, so it expects now that the same values are generated if no seed is
> provided.
> testing:
> ✅ tier1
> ✅ `test/lib-test/jdk/test/lib/` against personal build on linux,windows,macos-x64
> ✅ `test/lib-test/jdk/test/lib/` against CI build on linux,windows,macos-x64
This pull request has now been integrated.
Changeset: ac772cd9
Author: Igor Ignatyev <iignatyev at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/ac772cd9
Stats: 58 lines in 2 files changed: 44 ins; 5 del; 9 mod
8253750: use build-stable default seed for Utils.RANDOM_GENERATOR
Reviewed-by: rriggs
-------------
PR: https://git.openjdk.java.net/jdk/pull/391
More information about the core-libs-dev
mailing list