RFR: 8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]"

Aleksey Shipilev shade at openjdk.java.net
Wed Oct 7 07:28:08 UTC 2020


On Fri, 2 Oct 2020 17:36:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> The HexPrinter test utility should be ignoring \r characters from the formatter.
> It looks for \n and generates System.lineSeparator() at the end of each line.
> 
> With this fix, the ASN1FormatterTest can be removed from the ProblemList.

I am puzzled about this change. I feels weird to drop proper line separator from `ASN1Formatter` to please the test.
And it does not even look complete, because `ASN1Formatter` still uses `String.format("...%n", ...)` sometimes, that
still uses system line separator.

Can the test be made resilient by watching out for `lineSeparator()`, instead of just `\n`?

-------------

PR: https://git.openjdk.java.net/jdk/pull/486


More information about the core-libs-dev mailing list