RFR: 8253876: jdk/test/lib/hexdump/ASN1FormatterTest.java fails with "AssertionError: Lines expected [126] but found [202]" [v2]

[Aleksey Shipilev]

On Wed, 7 Oct 2020 16:01:28 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The HexPrinter test utility should be ignoring \r characters from the formatter.
>> It looks for \n and generates System.lineSeparator() at the end of each line.
>> 
>> With this fix, the ASN1FormatterTest can be removed from the ProblemList.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use System.lineSeparator for line endings

This looks significantly better, thanks!

test/lib/jdk/test/lib/hexdump/ASN1Formatter.java line 169:

> 167:                 if (nbytes > 4) {
> 168:                     out.append("***** Tag: " + tagName(tag) +
> 169:                             ", Range of length error: " + len + " bytes");

I think you can break this line into `append`-s, while we are at it. But your choice.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/486