RFR: 8254262: jdk.test.lib.Utils::createTemp* don't pass attrs
Aleksey Shipilev
shade at openjdk.java.net
Thu Oct 8 18:58:27 UTC 2020
On Thu, 8 Oct 2020 18:32:15 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> `jdk.test.lib.Utils::createTempFile` and `createTempDirectory` methods accept `attrs`, but don't pass it to
> `java.nio.file.Files::createTempFile` and `createTempDirectory` methods respectively. could you please review this
> trivial patch which fixes that? Thanks,
> -- Igor
Looks fine. There seems to be no uses of `Utils.createTempFile` or `Utils.createTempDirectory` with extended
attributes, so there is no affected tests, and no further testing needed, right?
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/567
More information about the core-libs-dev
mailing list