RFR: 8254078: DataOutputStream is very slow post-disabling of Biased Locking [v5]

Aleksey Shipilev shade at openjdk.java.net
Mon Oct 12 18:24:16 UTC 2020


On Mon, 12 Oct 2020 18:13:50 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8254078: DataOutputStream is very slow post-disabling of Biased Locking
>
> test/micro/org/openjdk/bench/java/io/DataOutputStreamTest.java line 44:
> 
>> 42:     @Param({"4096"}) int size;
>> 43:     final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(size);
>> 44:     final File f = new File("DataOutputStreamTest.tmp");
> 
> This should be `File.createTempFile("DataOutputStreamTest", "out")`? This way you don't leave waste in current dir.

Can probably move all these initializations to `setup()`. It does not look like the fields `final`-ity matter for this
benchmark.

-------------

PR: https://git.openjdk.java.net/jdk/pull/542


More information about the core-libs-dev mailing list