RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v4]

[CoreyAshford]

On Mon, 12 Oct 2020 11:06:23 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> CoreyAshford has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - TestBase64.java: fix comment to correctly reflect actual intrinsic names.
>>    
>>    The intrinsic names that are visible with -XX:+PrintCompilation are encode
>>    and decode, rather than encodeBlock and decodeBlock.
>>  - stubGenerator_ppc.cpp: fix regression caused by change to using loop counter
>>    
>>    My original fix didn't account for the case where sl < block_size.  In the
>>    event sl < block_size, the shifted sl will become zero, so it should
>>    jump to the code that computes how much data was processed - 0 - and return.
>
> Test java/util/Base64/TestBase64.java failed on Power9:
> JavaTest Message: Test threw exception: java.lang.RuntimeException: Base64 decoding(String) failed!
> Seed from RandomFactory = -8714459054005749075L
> 
> java.lang.RuntimeException: Base64 decoding(String) failed!
> 	at TestBase64.checkEqual(TestBase64.java:523)
> 	at TestBase64.test(TestBase64.java:185)
> 	at TestBase64.main(TestBase64.java:61)

This latest push passes the regression test. I thought I had run it last time, though, which confuses me.

-------------

PR: https://git.openjdk.java.net/jdk/pull/293