RFR: 8254078: DataOutputStream is very slow post-disabling of Biased Locking [v4]
Andrew Haley
aph at openjdk.java.net
Tue Oct 13 12:39:28 UTC 2020
On Fri, 9 Oct 2020 12:50:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8254078: DataOutputStream is very slow post-disabling of Biased Locking
>
> test/micro/org/openjdk/bench/java/io/DataOutputStreamTest.java line 43:
>
>> 41: public static class BenchmarkState {
>> 42: @Param({"4096"}) int SIZE;
>> 43: @Param({"char", "short", "int", /*"string"*/}) String BASIC_TYPE;
>
> - Do we use `"string"` case or not?
> - Java style: all caps are reserved for `static final` fields, these should be `size` and `basicType`
> - JMH supports `@Param` over `Enum`-s, so this `String` dance does not seem necessary.
The "string" case is there but I haven't changed anything in String output for now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/542
More information about the core-libs-dev
mailing list