RFR: JDK-8252870: Finalize (remove "incubator" from) jpackage [v2]

[Kevin Rushforth]

On Tue, 13 Oct 2020 21:30:05 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Andy Herrick has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8252870: Finalize (remove "incubator" from) jpackage
>>     - reverting two auto-generated files, and changing module-info to "@since 16"
>
> src/jdk.jpackage/linux/classes/module-info.java.extra line 29:
> 
>> 27:     jdk.jpackage.internal.LinuxAppBundler,
>> 28:     jdk.jpackage.internal.LinuxDebBundler,
>> 29:     jdk.jpackage.internal.LinuxRpmBundler;
> 
> Not sure why it was changed. Looks like git recorded file renaming incorrectly.

Yes, sometime GIt / Github get a bit confused about identifying rename/copy when generating a diff for a renamed file
with changes. The result is correct, but the diff looks odd.

> src/jdk.jpackage/macosx/classes/module-info.java.extra line 30:
> 
>> 28:     jdk.jpackage.internal.MacAppStoreBundler,
>> 29:     jdk.jpackage.internal.MacDmgBundler,
>> 30:     jdk.jpackage.internal.MacPkgBundler;
> 
> Looks like another rename issue.

Yes (or more precisely another issue displaying the diffs for a renamed file with changes).

-------------

PR: https://git.openjdk.java.net/jdk/pull/633