RFR: 8251989: Hex formatting and parsing utility [v2]

Roger Riggs rriggs at openjdk.java.net
Wed Oct 14 13:50:13 UTC 2020


On Wed, 14 Oct 2020 09:53:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Various code review comments, rename UpperCase and LowerCase methods to match Character, remove unnecessary Class name
>>   qualifications, etc.
>
> src/java.base/share/classes/java/util/HexFormat.java line 538:
> 
>> 536:      * A {@code delimiter} appears after each formatted value, except the last.
>> 537:      * The {@code delimiter}s, {@code prefix}es, and {@code suffix}es strings must be present;
>> 538:      * they may be empty strings.
> 
> I'd rather use @linkplain than @code here, or just plain words with no formatting, to avoid mixing different types of
> fonts in a single word.

Simpler is better, I will remove all the {@code } mark up on delimiter*, prefix*, and suffix*.

-------------

PR: https://git.openjdk.java.net/jdk/pull/482


More information about the core-libs-dev mailing list