RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v4]

CoreyAshford github.com+51754783+coreyashford at openjdk.java.net
Tue Oct 20 16:45:23 UTC 2020


On Tue, 20 Oct 2020 16:17:15 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>>> Please update
>>> [compiler/graalunit/HotspotTest.java](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/graalunit/HotspotTest.java),
>>> and add the intrinsic signature.
>> 
>> It looks like that is auto-generated, but I will figure out what to modify so that the signature is added.
>
> @CoreyAshford apologies i pointed to the "umbrella" test that runs Graal unit tests, the actual test is
> [CheckGraalIntrinsics](https://github.com/openjdk/jdk/blob/master/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java)
> See this PR for an example: https://github.com/openjdk/jdk/pull/762

> @CoreyAshford apologies i pointed to the "umbrella" test that runs Graal unit tests, the actual test is
> [CheckGraalIntrinsics](https://github.com/openjdk/jdk/blob/master/src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java)
> See this PR for an example: #762

Thank you for providing the more accurate location.  I will push commits to fix this a bit later today.

-------------

PR: https://git.openjdk.java.net/jdk/pull/293


More information about the core-libs-dev mailing list