RFR: JDK-8253936 Replace <code>...</code> with {@code ...} for java.sql

[Lance Andersen]

On Fri, 16 Oct 2020 19:38:45 GMT, Vipin Sharma <vsharma at openjdk.org> wrote:

> <code>...</code> is replaced with {@code ...} in java.sql classes.
> Please review and sponsor this change.

Hi Vipin

Thank you for tackling this update.  There are a few required changes below.  I will also be going through the
generated javadoc to see if anything jumps out as well.

Best
Lance

src/java.sql/share/classes/java/sql/BatchUpdateException.java line 281:

> 279:    * @param reason a description of the exception
> 280:    * @param updateCounts an array of <code>int</code>, with each element
> 281:    *indicating the update count, <code>Statement.SUCCESS_NO_INFO</code> or

Please add a space before indicating

src/java.sql/share/classes/java/sql/DataTruncation.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

The copyright update is incorrect, it should be 1996, 2020

src/java.sql/share/classes/java/sql/DriverPropertyInfo.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

Please correct the copyright as mentioned above

src/java.sql/share/classes/java/sql/NClob.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

Please fix the copyright

src/java.sql/share/classes/java/sql/ResultSet.java line 2001:

> 1999:
> 2000:     /**
> 2001:      * Updates the designated column with a {@code float } value.

Please remove the space after float

src/java.sql/share/classes/java/sql/RowId.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2006, 2020, Oracle and/or its affiliates. All rights reserved.

Please fix the copyright

src/java.sql/share/classes/java/sql/SQLClientInfoException.java line 38:

> 36:  * atomically.  For those databases, it is possible that some of the client
> 37:  * info properties had been set even though the {@code Connection.setClientInfo}
> 38:  * method threw an exception.  An application can use the {@code getFailedProperties }

Please remove the extra space after getFailedProperties

src/java.sql/share/classes/java/sql/SQLDataException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2010, 2020, Oracle and/or its affiliates. All rights reserved.

Please fix the copyright

src/java.sql/share/classes/java/sql/SQLException.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2014, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLFeatureNotSupportedException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLIntegrityConstraintViolationException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLInvalidAuthorizationSpecException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLNonTransientConnectionException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLNonTransientConnectionException.java line 125:

> 123:
> 124:     /**
> 125:      * Constructs a {@code SQLTransientException} object

This should be SQLNonTransientConnectionException

src/java.sql/share/classes/java/sql/SQLNonTransientException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLNonTransientException.java line 122:

> 120:
> 121:     /**
> 122:      * Constructs a {@code SQLTransientException} object

Should be SQLNonTransiientException

src/java.sql/share/classes/java/sql/SQLPermission.java line 2:

> 1: /*
> 2:  * Copyright (c) 1999, 2017, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLRecoverableException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2006, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLSyntaxErrorException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLTimeoutException.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLTransactionRollbackException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLTransientConnectionException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLTransientException.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/SQLWarning.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/Types.java line 2:

> 1: /*
> 2:  * Copyright (c) 1996, 2014, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/java/sql/Wrapper.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2013, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/javax/sql/ConnectionEvent.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2006, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/javax/sql/ConnectionEventListener.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2001, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/javax/sql/RowSetEvent.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2006, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/javax/sql/RowSetListener.java line 2:

> 1: /*
> 2:  * Copyright (c) 2000, 2001, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

src/java.sql/share/classes/javax/sql/StatementEventListener.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2014, 2020, Oracle and/or its affiliates. All rights reserved.

please fix the copyright

-------------

Changes requested by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/707