RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v7]

Vladimir Kozlov kvn at openjdk.java.net
Wed Oct 21 20:16:16 UTC 2020


On Wed, 21 Oct 2020 01:51:26 GMT, CoreyAshford <github.com+51754783+CoreyAshford at openjdk.org> wrote:

>> This patch set encompasses the following commits:
>> 
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class - decodeBlock(), and provides a flexible API for the intrinsic.  The API is similar to the existing encodeBlock intrinsic.
>> - Adds the code in HotSpot to check and martial the new intrinsic's arguments to the arch-specific intrinsic implementation
>> - Adds a Power64LE-specific implementation of the decodeBlock intrinsic.
>> - Adds a JMH microbenchmark for both Base64 encoding and encoding.
>> - Enhances the JTReg hotspot intrinsic "TestBase64.java" regression test to more fully test both decoding and encoding.
>
> CoreyAshford has updated the pull request incrementally with one additional commit since the last revision:
> 
>   CheckGraalIntrinsics.java: fix copy/paste error

Changes requested by kvn (Reviewer).

test/hotspot/jtreg/compiler/intrinsics/base64/TestBase64.java line 29:

> 27:  * @summary tests java.util.Base64
> 28:  * @library /test/lib /
> 29:  * @build sun.hotspot.WhiteBox jdk.test.lib.Utils

Tier3 testing shows failures: java.lang.NoClassDefFoundError: jdk/test/lib/Platform
@iignatev pointed that you should not add jdk.test.lib.Utils to @build here - it will be built by jtreg in correct order.

-------------

PR: https://git.openjdk.java.net/jdk/pull/293


More information about the core-libs-dev mailing list