RFR: 8254854: [cgroups v1] Metric limits not properly detected on some join controller combinations

Bob Vandette bobv at openjdk.java.net
Thu Oct 22 15:48:18 UTC 2020


On Thu, 22 Oct 2020 15:42:34 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java line 165:
>> 
>>> 163: 
>>> 164:         if (controllerName != null && base != null) {
>>> 165:             for (String cName: controllerName.split(",")) {
>> 
>> The previous logic checked for base!=null.  Do you think this is no longer necessary?
>
> Isn't this what line 164 does?

Sorry, I missed the fact that line 164 was being retained.  I just saw a lot of line removal.  Looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/809


More information about the core-libs-dev mailing list