RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v8]

Thu Oct 22 22:09:17 UTC 2020

On Thu, 22 Oct 2020 14:24:34 GMT, Paul Murphy <github.com+12972156+pmur at openjdk.org> wrote:

>> CoreyAshford has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   TestBase64.java: remove jdk.test.lib.Utils from @build which was causing Tier3 failures.
>
> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 3878:
> 
>> 3876:             // |    Element    |             |                      |                      |             |             |                      |                      |             |
>> 3877:             // +===============+=============+======================+======================+=============+=============+======================+======================+=============+
>> 3878:             // | after vaddubm | 00||b0:0..5 | 00||b0:6..7||b1:0..3 | 00||b1:4..7||b2:0..1 | 00||b2:2..7 | 00||b3:0..5 | 00||b3:6..7||b4:0..3 | 00||b4:4..7||b5:0..1 | 00||b5:2..7 |
> 
> An extra line here showing how the 8 6-bit values above get mapping into 6 bytes greatly help my brain out. (likewise for the <P10 case below too)

Just to make sure I understand, you're not asking for a change here, is that right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/293