RFR: 8251989: Hex formatting and parsing utility [v8]

[Roger Riggs]

On Mon, 12 Oct 2020 21:17:47 GMT, Marcono1234 <github.com+11685886+Marcono1234 at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comment updates to class javadoc
>
> src/java.base/share/classes/java/util/HexFormat.java line 148:
> 
>> 146:     private static final byte[] LOWERCASE_DIGITS = {
>> 147:             '0' , '1' , '2' , '3' , '4' , '5' , '6' , '7',
>> 148:             '8' , '9' , 'a' , 'b' , 'c' , 'd' , 'e' , 'f',
> 
> Suggestion:
> 
>             '0', '1', '2', '3', '4', '5', '6', '7',
>             '8', '9', 'a', 'b', 'c', 'd', 'e', 'f',

Will remove the extra spaces.

> src/java.base/share/classes/java/util/HexFormat.java line 182:
> 
>> 180:     /**
>> 181:      * Returns a hexadecimal formatter with no delimiter and lowercase characters.
>> 182:      * The hex characters are lowercase and the delimiter, prefix, and suffix are empty.
> 
>> The hex characters are lowercase
> 
> This is already mentioned in the sentence before.

will remove the redundancy.

> src/java.base/share/classes/java/util/HexFormat.java line 195:
> 
>> 193: 
>> 194:     /**
>> 195:      * Returns a hexadecimal formatter with a {@code delimiter} and lowercase letters.
> 
> Suggestion:
> 
>      * Returns a hexadecimal formatter with a {@code delimiter} and lowercase characters.
> To be consistent with documentation of other methods.

Will correct

-------------

PR: https://git.openjdk.java.net/jdk/pull/482