RFR: 8238263: Create at-requires mechanism for containers [v2]
Igor Ignatyev
iignatyev at openjdk.java.net
Mon Oct 26 20:27:20 UTC 2020
On Mon, 26 Oct 2020 18:13:29 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
>> Please review this change to add an @requires mechanism called "jdk.containerized" to help mark tests that are incompatible with containers. Users would add "@requires jdk.containerized != true" to the incompatible tests and then use "make test ... OPTIONS=-Djdk.containerized=true" or "bash jib.sh mach5 -- remote-build-and-test ... --test-make-args JTREG=OPTIONS=-Djdk.containerized=true" to exclude those tests when testing with containers.
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>
> 8238263: Create at-requires mechanism for containers
LGTM, modulo my earlier comment/doubt about the name, but I don’t think it’s important enough
-------------
Marked as reviewed by iignatyev (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/844
More information about the core-libs-dev
mailing list