RFR: 8255231: Avoid upcalls when initializing the statSampler [v4]

Claes Redestad redestad at openjdk.java.net
Tue Oct 27 10:38:27 UTC 2020


On Mon, 26 Oct 2020 22:52:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Claes Redestad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 21 additional commits since the last revision:
>> 
>>  - Address review comments from David Holmes
>>  - Merge branch 'master' into com_ns
>>  - Refactor to remove stable_java_property_counters and clarify comments
>>  - Merge branch 'master' into com_ns
>>  - Revert unrelated changes to perfData
>>  - Merge branch 'master' into com_ns
>>  - Improve comments
>>  - typo
>>  - Missing definition
>>  - Extract the shorthand java.version from VersionProps and use it in StatSampler
>>  - ... and 11 more: https://git.openjdk.java.net/jdk/compare/94ef2dbc...8572159f
>
> Thanks for making the suggested changes.
> 
> I think we need a further RFE to add some error checking for the sizes of the various property strings in relation to the fixed size arrays that have been allocated to them.
> 
> Thanks,
> David

@dholmes @iklam: thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/802


More information about the core-libs-dev mailing list