RFR: 8253939: [TESTBUG] Increase coverage of the cgroups detection code [v3]

Aleksey Shipilev shade at openjdk.java.net
Wed Oct 28 09:54:20 UTC 2020


On Fri, 23 Oct 2020 15:51:47 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Test only change. With [JDK-8253435](https://bugs.openjdk.java.net/browse/JDK-8253435) a test has been added on the hotspot side, but nothing for the Java Metrics code. Same for [JDK-8252359](https://bugs.openjdk.java.net/browse/JDK-8252359).
>> 
>> When JDK-8217766 got fixed cgroup factories with the detection logic didn't exist so were harder to test. This patch adds tests for them too.
>> 
>> Thoughts?
>
> Severin Gehwolf has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.

This looks okay to me.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/609


More information about the core-libs-dev mailing list